Skip to content

Revert "do not patch the implicit scope of scala.Unit in Scala.js" #24475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2025
Merged

Revert "do not patch the implicit scope of scala.Unit in Scala.js" #24475

merged 1 commit into from
Nov 18, 2025
+10 −72

Conversation

@hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Nov 18, 2025

I'll unfortunately revert this change until we somehow have an actual platform dependent TASTy in the stdlib.

Reverts #24405
Closes #24467

@hamzaremmal hamzaremmal marked this pull request as ready for review November 18, 2025 17:58
@hamzaremmal hamzaremmal requested a review from a team as a code owner November 18, 2025 17:58
@hamzaremmal hamzaremmal added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 18, 2025
@hamzaremmal
Copy link
Member Author

hamzaremmal commented Nov 18, 2025

This is weird, I have it is a green PR and all the conditions are satisfied and yet auto-merge didn't work?!

@hamzaremmal hamzaremmal disabled auto-merge November 18, 2025 18:52
@hamzaremmal hamzaremmal merged commit df117fc into main Nov 18, 2025
88 of 89 checks passed
@hamzaremmal hamzaremmal deleted the revert-24405-unit-conversion-sjs branch November 18, 2025 18:52
@WojciechMazur WojciechMazur mentioned this pull request Nov 24, 2025
Merged
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Nov 24, 2025
WojciechMazur added a commit that referenced this pull request Nov 25, 2025
@WojciechMazur
Backport "Revert "do not patch the implicit scope of scala.Unit in …
fbbc51f 
…Scala.js"" to 3.8.0 (#24529)

Backports #24475 to the 3.8.0-RC2.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjrd sjrd sjrd approved these changes

Assignees

No one assigned

Labels

backport:done This PR was successfully backported.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scaja.js UndefOrOps not applied anymore.

4 participants

@hamzaremmal @sjrd @WojciechMazur